Changeset 9 in bookmarks for trunk/Bookmarks.pm

Timestamp:

03/25/12 15:45:11 (12 years ago)

Author:

peter

Message:

• use SQL::Interp to generate the SQL for Bookmarks::get_resources()
• Bookmarks::get_resources() accepts a limit parameter to add a limit to the SQL query
• added a feed run mode that returns an Atom feed of the most recent 12 bookmarks; can have an optional ?tag parameter that only looks for bookmarks with that tag
• added an explicit "list" dispatch target that calls the `list run mode

File:

• trunk/Bookmarks.pm (modified) (2 diffs)

trunk/Bookmarks.pm

@@ -2 +2 @@
 
 use Class::Accessor 'antlers';
+use SQL::Interp qw{:all};
 use Bookmark;
 
@@ -36 +37 @@
     my $params = shift;
     my $tag = $params->{tag};
-    my $sth_resource;
-    if ($tag) {
-        $sth_resource = $self->dbh->prepare('select * from resources join tags on resources.uri = tags.uri join bookmarks on resources.uri = bookmarks.uri where tags.tag = ? order by ctime desc');
-        $sth_resource->execute($tag);
-    } else {
-        $sth_resource = $self->dbh->prepare('select * from resources join bookmarks on resources.uri = bookmarks.uri order by ctime desc');
-        $sth_resource->execute;
-    }
+    my $limit = $params->{limit};
+
+    my ($sql, @bind) = sql_interp(
+        'select * from resources join bookmarks on resources.uri = bookmarks.uri',
+        ($tag   ? ('join tags on resources.uri = tags.uri where tags.tag =', \$tag) : ''),
+        'order by ctime desc',
+        ($limit ? ('limit', \$limit) : ''),
+    );
+
+    my $sth_resource = $self->dbh->prepare($sql);
+    $sth_resource->execute(@bind);
 
     my $sth_tag = $self->dbh->prepare('select tag from tags where uri = ? order by tag');