Changeset 71 in bookmarks for trunk

Timestamp:

02/13/14 16:10:42 (11 years ago)

Author:

peter

Message:

• added a Bookmarks::Search class that encapsulates the query, tags, limit, and offset values for a given search
• Bookmarks::List now has a search attribute that takes a Bookmarks::Search object instead of the individual attributes from the search
• Bookmarks::get_cotags() takes a Bookmarks::Search object as its search parameter instead of discrete tags and query parameters
• changed the name of the Bookmarks::get_bookmarks() parameter from tag to tags to align with the rest of the backend APIs

Location:

trunk/lib

Files:

• Bookmarks.pm (modified) (5 diffs)
• Bookmarks/Controller.pm (modified) (2 diffs)
• Bookmarks/List.pm (modified) (2 diffs)
• Bookmarks/Search.pm (added)

trunk/lib/Bookmarks.pm

@@ -2 +2 @@
 
 use Moose;
+
 use SQL::Interp qw{:all};
 use URI;
+
 use Bookmark;
 use Bookmarks::List;
+use Bookmarks::Search;
 
 has dbh      => ( is => 'rw' );
@@ -73 +76 @@
     my $self = shift;
     my $params = shift;
-    my $query = $params->{query};
-    my $tags = $params->{tag} || [];
-    my $limit = $params->{limit};
-    my $offset = $params->{offset};
+    my $search = Bookmarks::Search->new($params);
 
     # build the query
     my @sql;
 
-    if (!ref $tags) {
-        $tags = [ $tags ];
-    }
-    if (@$tags) {
+    if (@{ $search->tags }) {
         my $intersect = 0;
-        for my $tag (@{ $tags }) {
+        for my $tag (@{ $search->tags }) {
             push @sql, 'intersect' if $intersect;
             push @sql, 'select resources.*, bookmarks.* from resources join bookmarks on resources.uri = bookmarks.uri';
@@ -95 +92 @@
         push @sql, 'select * from resources join bookmarks on resources.uri = bookmarks.uri';
     }
-    if ($query) {
-        push @sql, (@$tags ? 'and' : 'where'), 'title like', \"%$query%";
+    if ($search->query) {
+        my $fuzzy_match = '%' . $search->query . '%';
+        push @sql, (@{ $search->tags } ? 'and' : 'where'), 'title like', \$fuzzy_match;
     }
     push @sql, 'order by ctime desc';
-    push @sql, ('limit', \$limit) if $limit;
+    push @sql, ('limit', \$search->limit) if $search->limit;
     # an offset is only allowed if we have a limit clause
-    push @sql, ('offset', \$offset) if $limit && $offset;
+    push @sql, ('offset', \$search->offset) if $search->limit && $search->offset;
 
     my ($sql, @bind) = sql_interp(@sql);
-    #die $sql;
 
     my $sth_resource = $self->dbh->prepare($sql);
@@ -119 +116 @@
     return Bookmarks::List->new({
         bookmarks => $self,
-        tags      => $tags,
-        query     => $query,
-        limit     => $limit,
-        offset    => $offset,
+        search    => $search,
         results   => \@resources,
     });
@@ -147 +141 @@
     my $self = shift;
     my $params = shift;
-    my $query = $params->{query};
-    my $tags = $params->{tag} || [];
-    if (!ref $tags) {
-        $tags = [ $tags ];
-    }
+    my $search = $params->{search};
+
     my @sql;
 
     push @sql, 'select tag, count(tag) as count from tags';
-    push @sql, 'join resources on tags.uri = resources.uri' if $query;
+    push @sql, 'join resources on tags.uri = resources.uri' if $search->query;
 
     # build the where clause
-    if (@$tags) {
+    if (@{ $search->tags }) {
         push @sql, 'where tags.uri in (';
         my $intersect = 0;
-        for my $tag (@{ $tags }) {
+        for my $tag (@{ $search->tags }) {
             push @sql, 'intersect' if $intersect;
             push @sql, 'select uri from tags where tag = ', \$tag;
             $intersect++;
         }
-        push @sql, ') and tag not in ', $tags, '';
-    }
-    if ($query) {
-        push @sql, (@$tags ? 'and' : 'where'), 'title like', \"%$query%";
+        push @sql, ') and tag not in ', $search->tags, '';
+    }
+    if ($search->query) {
+        my $fuzzy_match = '%' . $search->query . '%';
+        push @sql, (@{ $search->tags } ? 'and' : 'where'), 'title like', \$fuzzy_match;
     }
 

trunk/lib/Bookmarks/Controller.pm

@@ -85 +85 @@
     my $list = $self->bookmarks->get_bookmarks({
         query  => $query,
-        tag    => \@tags,
+        tags   => \@tags,
         limit  => $limit,
         offset => $offset,
@@ -104 +104 @@
 
     # construct a feed from the most recent 12 bookmarks
-    my $list = $self->bookmarks->get_bookmarks({ query => $query, tag => \@tags, limit => 12 });
+    my $list = $self->bookmarks->get_bookmarks({ query => $query, tags => \@tags, limit => 12 });
     return $list->as_atom;
 }

trunk/lib/Bookmarks/List.pm

@@ -6 +6 @@
 use HTTP::Date qw{time2iso time2isoz};
 
-has bookmarks => (is => 'ro');
-has query  => (is => 'ro');
-has tags   => (
+has bookmarks => (
     is => 'ro',
-    default => sub { [] },
+    isa => 'Bookmarks',
 );
-has limit  => (is => 'ro');
-has offset => (is => 'ro');
+has search => (
+    is => 'ro',
+    isa => 'Bookmarks::Search',
+    handles => [qw{query tags limit offset}],
+);
 has results => ( is => 'ro' );
 has title => (
@@ -182 +183 @@
 
     my @all_tags = $self->bookmarks->get_tags({ selected => @{ $self->tags }[0] });
-    my @cotags = $self->bookmarks->get_cotags({
-        query  => $self->query,
-        tag    => $self->tags,
-    });
+    my @cotags = $self->bookmarks->get_cotags({ search => $self->search });
 
     $template->process(