Changeset 4 in flacrip for trunk/MusicBrainz.pm

Timestamp:

07/26/12 21:33:59 (12 years ago)

Author:

peter

Message:

• the MusicBrainz XML parsing returns the actual strings instead of XML::XPath::Literal elements
• flactrack takes an --all parameter that transcodes all of the tracks for a particular flac file into a directory (directory name defaults to the same as the flac filename, but without the ".flac" extension)

File:

• trunk/MusicBrainz.pm (modified) (2 diffs)

trunk/MusicBrainz.pm

@@ -47 +47 @@
     my $release_count = $xpath->findvalue('count(//release)');
     my ($release) = $xpath->findnodes('//release[1]');
-    $info{RELEASE_MBID} = $xpath->findvalue('@id', $release);
-    $info{ALBUM}        = $xpath->findvalue('title', $release);
-    $info{ARTIST}       = $xpath->findvalue('artist-credit/name-credit/artist/name', $release);
+    $info{RELEASE_MBID} = $xpath->findvalue('@id', $release)->value;
+    $info{ALBUM}        = $xpath->findvalue('title', $release)->value;
+    $info{ARTIST}       = $xpath->findvalue('artist-credit/name-credit/artist/name', $release)->value;
 
     # TODO: get release date
@@ -58 +58 @@
         my $prefix = sprintf('TRACK%02d', $tracknum);
         #$info{"$prefix.MB_TRACKID"} = $xpath->findvalue('@id', $track_node);
-        my $recording_mbid = $info{"$prefix.RECORDING_MBID"} = $xpath->findvalue('recording/@id', $track_node);
-        $info{"$prefix.TITLE"}          = $xpath->findvalue('recording/title', $track_node);
-        $info{"$prefix.ARTIST"}         = $xpath->findvalue('recording/artist-credit/name-credit/artist/name', $track_node) || $info{ARTIST};
+        my $recording_mbid = $info{"$prefix.RECORDING_MBID"} = $xpath->findvalue('recording/@id', $track_node)->value;
+        $info{"$prefix.TITLE"}          = $xpath->findvalue('recording/title', $track_node)->value;
+        $info{"$prefix.ARTIST"}         = $xpath->findvalue('recording/artist-credit/name-credit/artist/name', $track_node)->value || $info{ARTIST};
         $info{TRACKS}[$tracknum]{TITLE} = $info{"$prefix.TITLE"};
         $info{TRACKS}[$tracknum]{ARTIST} = $info{"$prefix.ARTIST"};