Changeset 67 in bookmarks

Timestamp:

02/04/14 15:31:28 (11 years ago)

Author:

peter

Message:

changed method name in BookmarkController from _check_modified() to _request_is_newer_than()

File:

• trunk/BookmarkController.pm (modified) (3 diffs)

trunk/BookmarkController.pm

@@ -306 +306 @@
 }
 
-#TODO: better method name
 # returns 1 if there is an If-Modified-Since header and it is newer than the given $mtime
 # returns 0 if there is an If-Modified-Since header but the $mtime is newer
 # returns undef if there is no If-Modified-Since header
-sub _check_modified {
+sub _request_is_newer_than {
     my $self = shift;
     my $mtime = shift;
@@ -330 +329 @@
     my $bookmark = $self->get_bookmark({ id => $id });
     if ($bookmark) {
-        return [304, [], []] if $self->_check_modified($bookmark->mtime);
+        return [304, [], []] if $self->_request_is_newer_than($bookmark->mtime);
 
         my $last_modified = time2str($bookmark->mtime);
@@ -357 +356 @@
     my $bookmark = $self->get_bookmark({ id => $id });
     if ($bookmark) {
-        return [304, [], []] if $self->_check_modified($bookmark->mtime);
+        return [304, [], []] if $self->_request_is_newer_than($bookmark->mtime);
 
         # check whether the requested field is part of the bookmark