Changeset 63 in bookmarks

Timestamp:

09/06/13 11:47:20 (11 years ago)

Author:

peter

Message:

• renamed controller methods:
  • create --> create_and_redirect
  • edit --> update_and_redirect
• use Moose instrospection instead of exception handling to determine if a requested field is available on a bookmark
• removed a debugging response line

Location:

trunk

Files:

• BookmarkController.pm (modified) (3 diffs)
• app.psgi (modified) (2 diffs)

trunk/BookmarkController.pm

@@ -360 +360 @@
         return [304, [], []] if $self->_check_modified($bookmark->mtime);
 
+        # check whether the requested field is part of the bookmark
+        if (!$bookmark->meta->has_attribute($field)) {
+            return [404, ['Content-Type' => 'text/plain; charset=UTF-8'], [qq{"$field" is not a valid bookmark data field}]];
+        }
+
         # respond with just the requested field as plain text
-        my $value = eval { $bookmark->$field };
-        if ($@) {
-            if ($@ =~ /Can't locate object method/) {
-                return [404, ['Content-Type' => 'text/plain; charset=UTF-8'], [qq{"$field" is not a valid bookmark data field}]];
-            } else {
-                die $@;
-            }
-        }
+        my $value = $bookmark->$field;
         my $last_modified = time2str($bookmark->mtime);
         return [200, ['Content-Type' => 'text/plain; charset=UTF-8', 'Last-Modified' => $last_modified], [ref $value eq 'ARRAY' ? join(' ', @{ $value }) : $value]];
@@ -376 +374 @@
 }
 
-sub create {
+sub create_and_redirect {
     my $self = shift;
 
@@ -393 +391 @@
 }
 
-sub edit {
+sub update_and_redirect {
     my $self = shift;
     my $id = shift;

trunk/app.psgi

@@ -48 +48 @@
 
             # create the bookmark and redirect to the new bookmark's edit form
-            return $controller->create;
+            return $controller->create_and_redirect;
         };
     };
@@ -85 +85 @@
             my $controller = get_controller($req);
 
-            return $controller->edit($params->{id});
-
-            return [200, ['Content-Type' => 'text/plain'], ['update ', $params->{id}]];
+            return $controller->update_and_redirect($params->{id});
         };
     };