Changeset 61 in bookmarks

Timestamp:

08/23/13 16:50:59 (11 years ago)

Author:

peter

Message:

• wrap the creation of the Bookmarks object into the BookmarkController
• bookmark is a lazy-loaded read-only attribute with a builder in BookmarkController
• made dbname and request required attributes of BookmarkController
• updated the api notes

Location:

trunk

Files:

• BookmarkController.pm (modified) (2 diffs)
• api (modified) (2 diffs)
• app.psgi (modified) (2 diffs)

trunk/BookmarkController.pm

@@ -9 +9 @@
 use Template;
 
+has dbname => (
+    is => 'ro',
+    required => 1,
+);
 has bookmarks => (
-    is => 'rw',
+    is => 'ro',
     handles => [qw{get_bookmark}],
+    builder => '_build_bookmarks',
+    lazy => 1,
 );
 has base_uri => (
@@ -20 +26 @@
 has request => (
     is => 'ro',
+    required => 1,
 );
+
+sub _build_bookmarks {
+    my $self = shift;
+    return Bookmarks->new({
+        dbname   => $self->dbname,
+        base_uri => $self->base_uri,
+    });
+}
 
 sub _build_base_uri {

trunk/api

@@ -3 +3 @@
 
   Params:
-    format=json|xbel
+    format=json|xbel|text|csv|html
     tag={tag} (repeatable)
     limit={limit}
@@ -16 +16 @@
 GET /feed
   Gets an Atom feed of the bookmarks
+
+  Params:
+    tag={tag} (repeatable)
 
 POST /

trunk/app.psgi

@@ -8 +8 @@
 
 use BookmarkController;
-use Bookmarks;
 
 #TODO: allow a different config file on the command line, or set options from the command line
@@ -19 +18 @@
     my $req = shift;
 
-    my $controller = BookmarkController->new({
+    return BookmarkController->new({
         request => $req,
+        dbname  => $config->{dbname},
     });
-    my $bookmarks = Bookmarks->new({
-        dbname   => $config->{dbname},
-        base_uri => $controller->base_uri,
-    });
-    $controller->bookmarks($bookmarks);
-    return $controller;
 }