Changeset 57 in bookmarks for trunk

Timestamp:

08/16/13 00:09:23 (11 years ago)

Author:

peter

Message:

• include a Last-Modified header in the HTML list and individual bookmark view
• added a get_last_modified_time() method to Bookmarks that return the time of the most recently modified bookmark
• for the individual bookmark view, check the Is-Modified-Since header and return a 304 response if the bookmark is unchanged

Location:

trunk

Files:

• BookmarkApp.pm (modified) (5 diffs)
• Bookmarks.pm (modified) (1 diff)

trunk/BookmarkApp.pm

@@ -7 +7 @@
 
 use Encode;
-use HTTP::Date qw{time2isoz time2iso};
+use HTTP::Date qw{time2isoz time2iso time2str str2time};
 use JSON;
 use Bookmarks;
@@ -135 +135 @@
 
     # list all the bookmarks 
+    my $mtime = $self->_bookmarks->get_last_modified_time;
+
     my $format = $q->param('format') || 'html';
 
@@ -239 +241 @@
             -type    => 'text/html',
             -charset => 'UTF-8',
+            -Last_Modified => time2str($mtime),
         );
 
@@ -335 +338 @@
     my $bookmark = $self->_bookmarks->get_bookmark({ id => $id });
     if ($bookmark) {
+        # check If-Modified-Since header to return cache response
+        if ($self->query->env->{HTTP_IF_MODIFIED_SINCE}) {
+            my $cache_time = str2time($self->query->env->{HTTP_IF_MODIFIED_SINCE});
+            if ($bookmark->mtime <= $cache_time) {
+                $self->header_type('redirect');
+                $self->header_props(
+                    -status => 304,
+                );
+                return;
+            }
+        }
+        
         if ($format eq 'json') {
             $self->header_props(
@@ -349 +364 @@
                 -type    => 'text/html',
                 -charset => 'UTF-8',
+                -Last_Modified => time2str($bookmark->mtime),
             );
             return $self->tt_process(

trunk/Bookmarks.pm

@@ -169 +169 @@
     $sth->execute(@bind);
     return @{ $sth->fetchall_arrayref({}) };
+}
+
+sub get_last_modified_time {
+    my $self = shift;
+    my $sth = $self->dbh->prepare('select mtime from bookmarks order by mtime desc limit 1');
+    $sth->execute;
+    my ($mtime) = $sth->fetchrow_array;
+    return $mtime;
 }