Changeset 5 in flacrip for trunk

Timestamp:

05/06/13 15:47:48 (11 years ago)

Author:

peter

Message:

• mbz: only print non-ref values of the info
• use-cases: added note about submitting a new discid
• flactrack:
  • hardcoded the library location for now
  • sort the supplied %TRACKS by their keys
  • remove special characters from the output filename using quotemeta
  • abort with an error message if no MusicBrainz info is found
  • abort with an error message if the flac decoding is canceled
• MusicBrainz.pm: select the proper medium (by DiscID) as the context for querying the tracklist, so multi-disc releases get the proper tracklist

Location:

trunk

Files:

• MusicBrainz.pm (modified) (1 diff)
• flactrack (modified) (5 diffs)
• mbz (modified) (1 diff)
• use-cases (modified) (1 diff)

trunk/MusicBrainz.pm

@@ -53 +53 @@
     # TODO: get release date
 
+    # select the proper medium (important for multidisc releases)
+    my ($medium) = $xpath->findnodes("medium-list/medium[disc-list/disc/\@id='$discid']", $release);
+
     my $ua = LWP::UserAgent->new;
     my $tracknum = 1;
-    for my $track_node ($xpath->findnodes('.//track-list/track', $release)) {
+    for my $track_node ($xpath->findnodes('track-list/track', $medium)) {
         my $prefix = sprintf('TRACK%02d', $tracknum);
         #$info{"$prefix.MB_TRACKID"} = $xpath->findvalue('@id', $track_node);

trunk/flactrack

@@ -11 +11 @@
 use File::Path;
 use Audio::FLAC::Header;
+#TODO: put the MusicBrainz lib in a more common location
+use lib qw{/home/peter/projects/flacrip};
 use MusicBrainz;
 
@@ -43 +45 @@
 if ($ALL) {
     die "Use of --all requires a --directory\n" unless $DIRECTORY;
+    die "No track info found on MusicBrainz for $FLAC_FILE\n" unless $info;
     use YAML;
     my $cuesheet = $flac->cuesheet;
@@ -51 +54 @@
         $_ => catfile($DIRECTORY, sprintf('%02d.%s', $_, to_filename($info->{TRACKS}[$_]{TITLE})))
     } (1 .. $count);
-    print Dump(\%TRACKS);
+    #print Dump(\%TRACKS);
+    for my $tracknum (sort { $a <=> $b } keys %TRACKS) {
+        printf "%2d: %s\n", $tracknum, $TRACKS{$tracknum};
+    }
     mkpath($DIRECTORY);
 }
 
-while (my ($tracknum, $title) = each %TRACKS) {
+#TODO: all the option of sorting by tracknum or not
+#while (my ($tracknum, $title) = each %TRACKS) {
+for my $tracknum (sort { $a <=> $b } keys %TRACKS) {
     if ($tracknum !~ /^\d+$/) {
         warn "Don't know what to do with track number '$tracknum'";
@@ -68 +76 @@
     }
 
-    $title = quotemeta($title);
+    my $title = quotemeta($TRACKS{$tracknum});
     if ($TYPE eq 'mp3') {
         # bitrate of 192
@@ -89 +97 @@
     #die $cmd;
     system $cmd;
+    die "\nFLAC decoding canceled\n" if ($? & 127);
 
     print "\n" if $SOX_FILTER;

trunk/mbz

@@ -41 +41 @@
 } else {
     for my $key (sort keys %{ $info }) {
-        print "$key=$$info{$key}\n";
+        print "$key=$$info{$key}\n" unless ref $info->{$key};
     }
 }

trunk/use-cases

@@ -19 +19 @@
 
 re-encode a mix as an archived flac for quick burning later
+
+submit a CD TOC to MusicBrainz
+    => submiturl
+    => metaflac --extract-cuesheet-to - | cuesheet2tocdata