Changeset 35 in bookmarks

Timestamp:

05/25/13 02:01:08 (12 years ago)

Author:

peter

Message:

simplified the processing of the tag query parameter

File:

• trunk/BookmarkApp.pm (modified) (4 diffs)

trunk/BookmarkApp.pm

@@ -69 +69 @@
     # list all the bookmarks 
     my $format = $q->param('format') || 'html';
-    my $tag = $q->param('tag');
-    my @tags = $q->param('tag');
-    # special case: handle the empty tag
-    if (@tags == 1 && $tags[0] eq '') {
-        @tags = ();
-    }
+
+    my @tags = grep { $_ ne '' } $q->param('tag');
     my $limit = $q->param('limit');
     my $offset = $q->param('offset');
@@ -82 +78 @@
         offset => $offset,
     });
-    my @all_tags = $bookmarks->get_tags({ selected => $tag });
+    my @all_tags = $bookmarks->get_tags({ selected => $tags[0] });
     my @cotags = $bookmarks->get_cotags({ tag => \@tags });
     
@@ -186 +182 @@
                 base_url     => $base_url,
                 title        => $title,
-                selected_tag => $tag,
+                selected_tag => $tags[0],
                 search_tags  => \@tags,
                 links        => \@links,
@@ -201 +197 @@
     my $q = $self->query;
 
-    my $tag = $q->param('tag');
-    my @tags = $q->param('tag');
-    # special case: handle the empty tag
-    if (@tags == 1 && $tags[0] eq '') {
-        @tags = ();
-    }
-
+    my @tags = grep { $_ ne '' } $q->param('tag');
     my $title = 'Bookmarks' . (@tags ? " tagged as " . join(' & ', @tags) : '');