Changeset 29 in flacrip

Timestamp:

11/05/14 01:06:55 (9 years ago)

Author:

peter

Message:

• added types to the attributes in the Tracks and Ripper classes
• removed get_cuesheet from the list of mathods handled by the Tracks class for the Ripper class

Location:

trunk/lib

Files:

• Ripper.pm (modified) (2 diffs)
• Tracks.pm (modified) (2 diffs)

trunk/lib/Ripper.pm

@@ -9 +9 @@
 use File::Copy;
 
-has device => ( is => 'rw' );
+has device => (
+    is  => 'rw',
+    isa => 'Str',
+);
 has tracks => ( 
-    is => 'rw',
-    handles => [qw{read_disc has_tracks get_cuesheet}],
+    is      => 'rw',
+    isa     => 'Tracks',
+    handles => [qw{read_disc has_tracks}],
 );
 
@@ -36 +40 @@
     # encode + cuesheet
     open my $CUE, "> $cue_file";
-    print $CUE $self->get_cuesheet;
+    print $CUE $self->tracks->get_cuesheet;
     close $CUE;
     system 'flac', '-o', $flac_file, '--cuesheet', $cue_file, $wav_file;

trunk/lib/Tracks.pm

@@ -21 +21 @@
 has tracks => (
     is      => 'rw',
+    isa     => 'ArrayRef[HashRef]',
     default => sub { [] },
 );
@@ -26 +27 @@
 has discid => (
     is       => 'ro',
+    isa      => 'Str',
     builder  => '_calculate_musicbrainz_discid',
     lazy     => 1,