Changeset 27 in bookmarks

Timestamp:

05/23/13 00:54:34 (11 years ago)

Author:

peter

Message:

• protect the specific field request with an eval; if it fails because the method is not found, respond with a 404
• use the JSON convert_blessed in the single bookmark view
• use the accessors instead of the direct hash calls for ctime and mtime

File:

• trunk/BookmarkApp.pm (modified) (2 diffs)

trunk/BookmarkApp.pm

@@ -236 +236 @@
         if ($field) {
             # respond with just the requested field as plain text
+            my $value = eval { $bookmark->$field };
+            if ($@) {
+                if ($@ =~ /Can't locate object method/) {
+                    $self->header_props(
+                        -type    => 'text/plain',
+                        -charset => 'UTF-8',
+                        -status  => 404,
+                    );
+                    return qq{"$field" is not a valid bookmark data field};
+                } else {
+                    die $@;
+                }
+            }
             $self->header_props(
                 -type    => 'text/plain',
                 -charset => 'UTF-8',
             );
-            my $value = $bookmark->{$field};
             return ref $value eq 'ARRAY' ? join(',', @{ $value }) : $value;
         } else {
@@ -248 +260 @@
                     -charset => 'UTF-8',
                 );
-                return decode_utf8(encode_json($bookmark));
+                return decode_utf8(JSON->new->utf8->convert_blessed->encode($bookmark));
             } else {
                 # display the bookmark form for this bookmark
                 $bookmark->{exists} = 1;
-                $bookmark->{created} = "Created " . localtime($bookmark->{ctime});
-                $bookmark->{created} .= '; Updated ' . localtime($bookmark->{mtime}) unless $bookmark->{ctime} == $bookmark->{mtime};
+                $bookmark->{created} = "Created " . localtime($bookmark->ctime);
+                $bookmark->{created} .= '; Updated ' . localtime($bookmark->mtime) unless $bookmark->ctime == $bookmark->mtime;
                 $self->header_props(
                     -type    => 'text/html',