Changeset 25 in bookmarks for trunk

Timestamp:

05/23/13 00:37:57 (12 years ago)

Author:

peter

Message:

• Bookmark uses Moose
  • the Bookmarks base_uri should be passed to the constructor to set the bookmark_uri attribute of the Bookmark
  • added a TO_JSON method to serialize the URIs to strings for JSON
• use JSON::convert_blessed to trigger calling Bookmark::TO_JSON
• added a private _sth_tags_from_uri attribute to Bookmarks
• Bookmarks::get_tags can be called with a uri parameter to fetch a list of tags for that resource
• Bookmarks::get_bookmark() returns a Bookmark object
• Bookmarks::get_resources() returns an array of Bookmark objects

Location:

trunk

Files:

• Bookmark.pm (modified) (1 diff)
• BookmarkApp.pm (modified) (1 diff)
• Bookmarks.pm (modified) (5 diffs)

trunk/Bookmark.pm

@@ -1 +1 @@
 package Bookmark;
 
-use Class::Accessor qw{antlers};
+use Moose;
 
-has id    => ( is => 'ro' );
-has uri   => ( is => 'ro' );
-has ctime => ( is => 'ro' );
-has mtime => ( is => 'ro' );
+has id    => ( is => 'rw' );
+has uri   => ( is => 'rw' );
+has title => ( is => 'rw' );
+has ctime => ( is => 'rw' );
+has mtime => ( is => 'rw' );
+has tags  => ( is => 'rw' );
+has bookmark_uri => ( is => 'rw' );
+
+sub BUILD {
+    my $self = shift;
+    my $args = shift;
+    if ($args->{base_uri}) {
+        $self->bookmark_uri(URI->new_abs($self->id, $args->{base_uri}));
+    }
+}
+
+sub TO_JSON {
+    my $self = shift;
+    return {
+        id    => $self->id,
+        uri   => $self->uri,
+        title => $self->title,
+        ctime => $self->ctime,
+        mtime => $self->mtime,
+        tags  => $self->tags,
+        ($self->bookmark_uri ? (bookmark_uri => $self->bookmark_uri->canonical->as_string) : ()),
+    };
+}
 
 # module return

trunk/BookmarkApp.pm

@@ -90 +90 @@
         );
         return decode_utf8(
-            encode_json({
+            JSON->new->utf8->convert_blessed->encode({
                 bookmarks => \@resources,
             })

trunk/Bookmarks.pm

@@ -8 +8 @@
 has dbh      => ( is => 'rw' );
 has base_uri => ( is => 'ro', isa => 'URI' );
+
+has _sth_tags_from_uri => (
+    is       => 'ro',
+    init_arg => undef,
+    lazy     => 1,
+    default  => sub { $_[0]->dbh->prepare('select tag from tags where uri = ? order by tag'); },
+);
 
 sub BUILD {
@@ -29 +36 @@
     my $self = shift;
     my $params = shift;
+
+    # look for bookmark by id or uri
     my $sth;
     if ($params->{id}) {
@@ -40 +49 @@
     }
     my $bookmark = $sth->fetchrow_hashref;
-    if ($bookmark) {
-        my $sth_tag = $self->dbh->prepare('select tag from tags where uri = ? order by tag');
-        $sth_tag->execute($bookmark->{uri});
-        $bookmark->{tags} = [ map { $$_[0] } @{ $sth_tag->fetchall_arrayref } ];
-        if ($self->base_uri) {
-            $bookmark->{bookmark_uri} = URI->new_abs($bookmark->{id}, $self->base_uri);
-        }
-    }
-    return $bookmark;
+    return unless $bookmark;
+
+    return Bookmark->new({
+        %$bookmark,
+        tags     => [ $self->get_tags({ uri => $bookmark->{uri} }) ],
+        base_uri => $self->base_uri,
+    });
 }
 
@@ -85 +92 @@
     $sth_resource->execute(@bind);
 
-    my $sth_tag = $self->dbh->prepare('select tag from tags where uri = ? order by tag');
     my @resources;
     while (my $resource = $sth_resource->fetchrow_hashref) {
-        $sth_tag->execute($resource->{uri});
-        $resource->{tags} = [ map { $$_[0] } @{ $sth_tag->fetchall_arrayref } ];
-        if ($self->base_uri) {
-            $resource->{bookmark_uri} = URI->new_abs($resource->{id}, $self->base_uri);
-        }
-        push @resources, $resource;
+        push @resources, Bookmark->new({
+            %$resource,
+            tags     => [ $self->get_tags({ uri => $resource->{uri} }) ],
+            base_uri => $self->base_uri,
+        });
     }
     return @resources;
@@ -101 +106 @@
     my $self = shift;
     my $params = shift;
-    my $tag = $params->{selected};
-    my $sth_all_tags = $self->dbh->prepare('select tag, count(tag) as count, tag = ? as selected from tags group by tag order by tag');
-    $sth_all_tags->execute($tag);
-    my $all_tags = $sth_all_tags->fetchall_arrayref({});
-    return @{ $all_tags };
+    if (my $uri = $params->{uri}) {
+        # get the tags for a particular URI
+        $self->_sth_tags_from_uri->execute($uri);
+        return map { $$_[0] } @{ $self->_sth_tags_from_uri->fetchall_arrayref };
+    } else {
+        # return all tags
+        my $tag = $params->{selected};
+        my $sth_all_tags = $self->dbh->prepare('select tag, count(tag) as count, tag = ? as selected from tags group by tag order by tag');
+        $sth_all_tags->execute($tag);
+        my $all_tags = $sth_all_tags->fetchall_arrayref({});
+        return @{ $all_tags };
+    }
 }